Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pramodrj07 to the member list #493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add pramodrj07 to the member list #493

wants to merge 1 commit into from

Conversation

pramodrj07
Copy link

@google-cla google-cla bot added the cla: yes label Sep 21, 2021
@google-oss-robot
Copy link

Hi @pramodrj07. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pramodrj07
Copy link
Author

/assign @Bobgy

terrytangyuan
terrytangyuan approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pramodrj07, terrytangyuan
To complete the pull request process, please ask for approval from bobgy after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pramodrj07
Copy link
Author

Hi @Bobgy - Can we merge this if it is looking good?

@annajung
Copy link
Member

+1
/lgtm

@google-oss-robot
Copy link

@pramodrj07: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-internal-acls-github-org de166c3 link true /test kubeflow-internal-acls-github-org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pramodrj07
Copy link
Author

/restest

@pramodrj07
Copy link
Author

/test kubeflow-internal-acls-github-org

@google-oss-robot
Copy link

@pramodrj07: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test kubeflow-internal-acls-github-org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bobgy
Copy link
Contributor

Bobgy commented Nov 2, 2021

/ok-to-test
Thank you,
Can you fix the test?

@Bobgy
Copy link
Contributor

Bobgy commented Nov 2, 2021

/retest

Arhell
Arhell reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Arhell Arhell removed their assignment Feb 4, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@rimolive
Copy link
Member

rimolive commented Nov 5, 2024

@pramodrj07 Are you still willing to get membership?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@Bobgy Bobgy Awaiting requested review from Bobgy

@capri-xiyue capri-xiyue Awaiting requested review from capri-xiyue

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@Bobgy Bobgy

@annajung annajung

Labels
cla: yes lgtm lifecycle/stale ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pramodrj07 @google-oss-robot @annajung @Bobgy @rimolive @terrytangyuan @Arhell